Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand network fees #533

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Understand network fees #533

merged 7 commits into from
Apr 11, 2023

Conversation

earakel
Copy link
Contributor

@earakel earakel commented Mar 24, 2023

No description provided.

@earakel earakel linked an issue Mar 24, 2023 that may be closed by this pull request
@earakel earakel added doc-new Additions to the Status documentation E:Wallet Status Wallet labels Mar 24, 2023
@earakel earakel self-assigned this Mar 24, 2023
@earakel earakel changed the title Understand network fees / Draft Understand network fees Mar 24, 2023
Copy link
Contributor

@jorge-campo jorge-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, @shamisem - I'm afraid we need to rethink and rework this article. It relies too much on Ethereum PoW concepts that are no longer valid under the PoS consensus mechanism.

I propose you the following changes:

  • Since "gas fees" is a widely accepted term, I will introduce this earlier. "Network fees are charged by ..." -> "Network fees (also known as gas fees) are charged by ..."
  • About the admonition. "Status Wallet doesn't charge any extra transaction fees." We need to clarify this. While it's true that the Wallet doesn't charge fees, Status will charge fees when the user buys crypto using it (buying crypto is also a transaction, from the user's point of view). It's worth clarifying if there is any other case where we charge fees (not that I'm aware of). This is a question for John, and we should include this information in the article to be completely transparent.
  • "Status Wallet doesn't charge any extra transaction fees." See my previous comment. What about "Status Wallet doesn't charge any extra network fees."?
  • "You can set custom network fees for your ..." You can link here to your other article, "Handle pending or stuck transactions".
  • "When you send a blockchain transaction, it needs to be processed and validated by the network." I would slightly change this to "When you send a blockchain transaction, it needs to be processed and validated by the blockchain network." Your original sentence can make the user think there are transactions other than blockchain transactions to do with their Status Wallet.
  • "This involves the work of validators, who use powerful computers to validate transactions." -> "This involves the work of validators, who use powerful their computers to validate transactions." In Ethereum PoS, you no longer need a powerful computer to run transactions. Some implementations, like Nimbus, can be configured in a Raspberry Pi.
  • "By sending a transaction, you create a job validators compete for." This is no longer true in Ethereum PoS. Validators don't "compete" with each other. Validators are selected through a random process, and once they are selected, they create the block and include transactions in it. I won't go further into the details here because we'll have a dedicated article to explain the blockchain.
  • "A network fee's size depends on how busy the blockchain is, as well as the size of your transaction." -> "A network fee's size depends on how busy the blockchain is, as well as the size complexity of your transaction." Transacting higher amounts of crypto doesn't necessarily mean you'll pay more fees. It depends on the complexity of your transaction; more complexity means more resources and fees.
  • "Network fees are measured in gas, which in turn is measured in gwei." While this is correct, it makes things harder to understand. Network fees and gas fees are equivalent terms. I would say, "Network fees are measured in gwei."
  • "If you set your network fees too low, it may take longer for your transaction to be verified by the network. In some cases, it may never be processed at all." Again, this is the perfect place to link your other article, "Handle pending or stuck transactions".
  • "Blockchain transactions can be compared to job offers ..." Your analogy applies more to a PoW scenario. You can use ChatGPT to find an easy-to-understand analogy for the PoS scenario.
  • "Validators invest their time and resources into processing transactions, which includes using computer hardware that consumes electricity". Again, this doesn't apply to the Ethereum PoS consensus mechanism. The main goal of network fees is not to cover the validators' electricity bill but to incentivize validators for their work and contribution to the blockchain.

@earakel
Copy link
Contributor Author

earakel commented Apr 11, 2023

Hey @jorge-campo, thanks so much for your review!

  1. Extra fees clarification: Status Wallet doesn’t charge any extra _network_ fees _for sending transactions_.
  2. PoS/PoW: I revised the article to discuss PoS, not entirely sure what I was thinking...
  3. Linking other articles: Added To resend your transaction with a higher fee, check out [Handle pending or stuck transactions][handle-pending-or-stuck-transactions]. where relevant.

Everything else is implemented as well.

@earakel earakel merged commit 37e3b5f into develop Apr 11, 2023
@earakel earakel deleted the 469-understand-network-fees branch April 11, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-new Additions to the Status documentation E:Wallet Status Wallet
Projects
Status: Published/Done
Development

Successfully merging this pull request may close these issues.

Understand network fees
2 participants