Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

514 About community request approval #519

Closed
wants to merge 2 commits into from

Conversation

Fabiomorais87
Copy link
Contributor

Hi @shamisem,

Here is the PR for the article "About community request approval". I would appreciate any suggestions you have. I am not including the metadata since it is not part of the official review process. Thanks again!

Fabio


# About community request approval <!--include a plural on request or approval? ASk Emma-->

When a community requires [manual approval][link-here] for membership requests, the community owner reviews each request and decides based on their criteria. If you're a community owner and want to configure manual approval, read [set up your community's approval options][link to the article].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'the community owner <...> makes a decision'
  • 'configure' -> 'set up'
  • 'read' -> 'check out'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fabiomorais87 , @shamisem -- About the "read" vs. "check out".

This is a "read". If you're a community owner and want to configure manual approval, you must read the link; the rest of the article doesn't apply to you. Therefore, the link is not an optional "check this", it's a must "read" this.

I hope it makes sense!

When a community requires [manual approval][link-here] for membership requests, the community owner reviews each request and decides based on their criteria. If you're a community owner and want to configure manual approval, read [set up your community's approval options][link to the article].

!!! tip
In addition to manual approval, community owners may configure [token requirements][] to join their communities. Manual approval and token requirements work independently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'may' -> 'can'
  • 'configure' -> 'set up'

@Fabiomorais87 Fabiomorais87 deleted the 514-about-community-request-approval branch March 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants