Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the editing server of data.stattistik.at #26

Closed
3 of 4 tasks
GregorDeCillia opened this issue Mar 7, 2022 · 0 comments · Fixed by #23
Closed
3 of 4 tasks

Add support for the editing server of data.stattistik.at #26

GregorDeCillia opened this issue Mar 7, 2022 · 0 comments · Fixed by #23
Assignees
@GregorDeCillia
Labels
API
Milestone
Version 1.0

Comments

@GregorDeCillia
Copy link
Contributor

GregorDeCillia commented Mar 7, 2022 •
edited
Loading

Similar to #25 but for od_table(). Currently, the caches use something like ~/.cache/STATcubeR/open_data/{id}.csv which basically mimicks the file format from the servers. We will need a second cache directory or disable caching for the editing server.

  • add server parameter to od_table() to switch between the external server and the editing server
  • support caching for both servers with separate caching directories
  • documentation
  • parameter checking
@GregorDeCillia GregorDeCillia added this to the Version 1.0 milestone Mar 7, 2022
@GregorDeCillia GregorDeCillia self-assigned this Mar 7, 2022
GregorDeCillia added a commit that referenced this issue Mar 7, 2022
@GregorDeCillia
add server argument to od_list()
282a7de 
Add a parameter that allows to list all
datasets from the editing server instead of
the external one

part of #26
@GregorDeCillia GregorDeCillia linked a pull request Mar 7, 2022 that will close this issue
Document and export caching of API responses #23
Merged
5 tasks
GregorDeCillia added a commit that referenced this issue Mar 8, 2022
@GregorDeCillia
support editing server in od_table()
a8fcb94 
add a new "server" parameter that allows
to sitch between the external OGD server
and the OGD editing server. The cache
directory uses a subdirectory to cache
the responses from the editing server

TODO

- add documentation for new server
  parameter in od_table(), od_resource()
  and other affected functions
- Export functions that return base urls of
  the different servers. This is needed for
  a shiny app that is built on top of
  STATcubeR and links to the datasets
  via anchor tags
- extend the "resource management" vignette
  and mention how caching from the editing
  server is handled
- add parameter checking and throw errors
  if server is not "ext" or "red"

part of #26
GregorDeCillia added a commit that referenced this issue Mar 9, 2022
@GregorDeCillia
add server param to od_cache_summary()
b7ab2cb 
part of #26
GregorDeCillia added a commit that referenced this issue Mar 9, 2022
@GregorDeCillia
add parameter documentation for OGD-server
b322a4d 
#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregorDeCillia GregorDeCillia

Labels
API
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Document and export caching of API responses statistikat/STATcubeR
1 participant
@GregorDeCillia