-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6/parser for concrete syntax #35
Conversation
@marcosh Looks beautiful! I'm getting a compile error though:
|
87de21c
to
71d8269
Compare
yeah, sorry about that. It's not in a file I modified. |
Ah cool! It compiles now, thanks. I am getting tab errors though. Shall we follow ghc's advice to use spaces instead?
|
Oh, hmm, the tests won't compile it seems. I guess tests on master are broken? Unfortunately, that means we also can't test the parser, so we should make sure both the main and the test code compile. |
‘Stack test’ works for me - how are you compiling the tests?
… On Sep 17, 2018, at 6:05 PM, Erik Post ***@***.***> wrote:
Oh, hmm, the tests won't compile it seems. I guess tests on master are broken? Unfortunately, that means we also can't test the parser, so we should make sure both the main and the test code compile.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@wisnesky using |
@wisnesky was the tabs issue above addressed? |
Ahh I see, thanks Marco! |
almost complete
Schema
kind parsersome tests are still missing, so that part could be not 100% correct
also, some the tests on
schemaLiteralSectionParser
are failing quite rarely, so probably some edge case is not handled correctly