Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6/parser for concrete syntax #35

Merged
merged 12 commits into from
Sep 18, 2018
Merged

6/parser for concrete syntax #35

merged 12 commits into from
Sep 18, 2018

Conversation

marcosh
Copy link
Contributor

@marcosh marcosh commented Sep 17, 2018

almost complete Schema kind parser

some tests are still missing, so that part could be not 100% correct

also, some the tests on schemaLiteralSectionParser are failing quite rarely, so probably some edge case is not handled correctly

@epost
Copy link
Member

epost commented Sep 17, 2018

@marcosh Looks beautiful! I'm getting a compile error though:

/Users/erik/dev/statebox/aql/src/Language/AQL.hs:367:15: error:
    • Couldn't match type ‘c’ with ‘TypesideExp var0 ty0 sym0’
      ‘c’ is a rigid type variable bound by
        the type signature for:
          lookupProg :: forall c t col.
                        Syntax c t col =>
                        Program -> (String, Kind) -> Either String c
        at src/Language/AQL.hs:365:1-77
      Expected type: Either String c
        Actual type: Either [Char] (TypesideExp var0 ty0 sym0)

@marcosh
Copy link
Contributor Author

marcosh commented Sep 17, 2018

yeah, sorry about that. It's not in a file I modified.
Now I rebased on master and everything should work fine

@epost
Copy link
Member

epost commented Sep 17, 2018

Ah cool! It compiles now, thanks. I am getting tab errors though. Shall we follow ghc's advice to use spaces instead?

/Users/erik/dev/statebox/aql/src/Language/Typeside.hs:5:27: warning: [-Wtabs]
    Tab character found here, and in one further location.
    Please use spaces instead.
  |
5 | import Prelude hiding (EQ)
  |                           ^^^^^^
[12 of 19] Compiling Language.Schema  ( src/Language/Schema.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Schema.o )

/Users/erik/dev/statebox/aql/src/Language/Schema.hs:5:27: warning: [-Wtabs]
    Tab character found here, and in one further location.
    Please use spaces instead.
  |
5 | import Prelude hiding (EQ)
  |                           ^^^^^^
[13 of 19] Compiling Language.Query   ( src/Language/Query.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Query.o )

/Users/erik/dev/statebox/aql/src/Language/Query.hs:5:27: warning: [-Wtabs]
    Tab character found here, and in one further location.
    Please use spaces instead.
  |
5 | import Prelude hiding (EQ)
  |                           ^^^^^^
[14 of 19] Compiling Language.Mapping ( src/Language/Mapping.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Mapping.o )

/Users/erik/dev/statebox/aql/src/Language/Mapping.hs:5:27: warning: [-Wtabs]
    Tab character found here, and in one further location.
    Please use spaces instead.
  |
5 | import Prelude hiding (EQ)
  |                           ^^^^^^
[15 of 19] Compiling Language.Instance ( src/Language/Instance.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Instance.o )

/Users/erik/dev/statebox/aql/src/Language/Instance.hs:5:27: warning: [-Wtabs]
    Tab character found here, and in one further location.
    Please use spaces instead.
  |
5 | import Prelude hiding (EQ)
  |                           ^^^^^^

@epost
Copy link
Member

epost commented Sep 17, 2018

Oh, hmm, the tests won't compile it seems. I guess tests on master are broken? Unfortunately, that means we also can't test the parser, so we should make sure both the main and the test code compile.

@wisnesky
Copy link
Contributor

wisnesky commented Sep 17, 2018 via email

@epost
Copy link
Member

epost commented Sep 17, 2018

@wisnesky using stack test, like you; i just read the discussion at #34 (comment), but perhaps @marcosh rebased on a version of master before you pushed changes to fix failing tests? In that case, he should probably rebase (or merge, whichever is most convenient) again. Right Marco?

@wisnesky wisnesky merged commit ad134af into master Sep 18, 2018
@epost
Copy link
Member

epost commented Sep 18, 2018

@wisnesky was the tabs issue above addressed?

@marcosh
Copy link
Contributor Author

marcosh commented Sep 18, 2018

@epost I opened #37 to address that

@epost
Copy link
Member

epost commented Sep 18, 2018

Ahh I see, thanks Marco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants