Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-lambda attributes #54

Closed
wisnesky opened this issue Oct 10, 2018 · 8 comments
Closed

non-lambda attributes #54

wisnesky opened this issue Oct 10, 2018 · 8 comments
Assignees

Comments

@wisnesky
Copy link
Contributor

No description provided.

@wisnesky wisnesky self-assigned this Oct 10, 2018
@wisnesky
Copy link
Contributor Author

Should allow att1 -> att2 in addition to att1 -> lambda x. att2(x)

@wisnesky
Copy link
Contributor Author

This is in MapExpRaw. The 'x' in the lambda should be given a name that can't shadow any other name; in Aql java, we punted and just made up a name that is unlikely to appear elsewhere.

This is low priority but some Aql examples do rely on it.

@marcosh
Copy link
Contributor

marcosh commented Oct 16, 2018

It's not completely clear to me what needs to be done here, especially the part about the x.

Are you referring to https://github.com/CategoricalData/fql/blob/520e24963d399ef6e04e35d60f11a1e9f91e3c85/src/main/java/catdata/aql/exp/CombinatorParser.java#L1168?

Is it the problem the fact that you need a name of the attribute to return something of the type (String, (String, RawTerm))? If so, would it be ok to create a new datatype

data MappingAttributeTerm
    = MappingAttributeTermLambda String String RawTerm
    | MappingAttributeTermPath _

so that we could treat the two cases indipendently without reverting to strange tricks?

@wisnesky
Copy link
Contributor Author

wisnesky commented Oct 16, 2018 via email

@marcosh
Copy link
Contributor

marcosh commented Oct 18, 2018

@wisnesky I pushed on the branch https://github.com/statebox/aql/tree/54/non-lambda-attributes the parser for point free attributes.

I am a bit stuck though with the implementation of evalMappingRaw'. Would it be possible for you to help me with it? Maybe even with some pair programming

@wisnesky
Copy link
Contributor Author

wisnesky commented Oct 18, 2018 via email

@wisnesky
Copy link
Contributor Author

I went ahead and added this to the latest commit, but I re-did the parser stuff. I'm sorry Marco but I just can't seem to get my head around how your parsers map onto AQL syntax.

@marcosh
Copy link
Contributor

marcosh commented Oct 23, 2018

don't worry. You clearly have a clearer idea around this stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants