Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & clean up #148

Open
23 of 29 tasks
epost opened this issue Aug 7, 2019 · 0 comments
Open
23 of 29 tasks

Refactor & clean up #148

epost opened this issue Aug 7, 2019 · 0 comments
Assignees
@epost

Comments

@epost
Copy link
Member

epost commented Aug 7, 2019 •
edited
Loading

  • Reformat examples/*.cql.
  • Move code in Language to Language.CQL.
  • Move code in Parser.hs to Parser/Program.hs.
    • Simplify code.
    • Clarify variable naming.
  • Move QuickCheck generator for parsers under test dir tree.
  • Tighten imports.
  • Organise test code sensibly.
  • Move dependencies in packages.yaml from dependencies to test dependencies where possible.
  • Split off Morphism.hs from Term.hs.
  • Split off Collage.hs from Term.hs.
  • Split off Presentation.hs from Instance.hs
  • Split off Algebra.hs from Instance.hs
  • move assembleGens from Instance into Collage
  • rename simplifyFix to simplifyTheory in Term.hs
    • rename simplify to simplifyTheoryStep in Term.hs
  • Introduce Theory type alias in Term.hs
  • Rename findSimplifiable -> findSimplifiableEqs in Term.hs
  • Rename simplifyAlg -> A.simplify
  • Rename presToCol to IP.toCollage
  • Rename schToCol to Schema.toCollage
  • Refactor schToCol
    • modularise uppgrading of EQuations
  • Rename tsToCol to Typeside.toCollage
  • Rename xxxToCol to Xxx.toCollage
  • Rename checkSatisfaction -> I.satisfiesSchema
  • Rename typecheckPresentation -> IP.typecheck
  • Use Carrier type alias in Instance.hs
  • Split off Theory.hs from Term.hs? (Consider making it a submodule of something.)
@epost epost self-assigned this Aug 7, 2019
epost added a commit that referenced this issue Aug 7, 2019
@epost
Clean up formatting of examples. #148
40476b6
epost added a commit that referenced this issue Aug 8, 2019
@epost
Fix examples/Congruence.cql. #148
f974f3b
epost added a commit that referenced this issue Aug 11, 2019
@epost
Move modules to Language.CQL. #148
0e87dc5
epost added a commit that referenced this issue Aug 12, 2019
@epost
Clean up Program parsers. #148
e5f51b4
epost added a commit that referenced this issue Aug 12, 2019
@epost
Clean up Program parsers. #148
28d2571 
* Move into Language.CQL.Parser.Program.

* Simplify some of the stuff inside.
epost added a commit that referenced this issue Aug 12, 2019
@epost
Move QuickCheck generator for Parser into test dir. #148
294df80
epost added a commit that referenced this issue Aug 12, 2019
@epost
Move QuickCheck generator for Parser into test dir. #148
084c42f
epost added a commit that referenced this issue Aug 14, 2019
@epost
More cleanup. #148
e11eca6
epost added a commit that referenced this issue Aug 14, 2019
@epost
Segregate morphism code into Morphism.hs. #148
c0a2b80
epost added a commit that referenced this issue Aug 14, 2019
@epost
Tighten imports from Morphism. #148
9690d64
epost added a commit that referenced this issue Aug 14, 2019
@epost
Rename Morphism-related functions for clarity. #148
bd16d92
epost added a commit that referenced this issue Aug 14, 2019
@epost
Improve naming and qualification of Morphism-related functions. #148
8cd7f65
epost added a commit that referenced this issue Aug 14, 2019
@epost
Move Collage into its own separate module. #148
c4c14a5
epost added a commit that referenced this issue Aug 15, 2019
@epost
Move Collage into its own separate module. #148
667a1bb
epost added a commit that referenced this issue Aug 15, 2019
@epost
Fix typo in 'lower' doc comment. #148
89bf5db
epost added a commit that referenced this issue Aug 15, 2019
@epost
148/more cleanup (WIP) (#150)
d911bab 
* Some cleanup and explicit typing. 148.

* Move modules to Language.CQL. #148

* Clean up Program parsers. #148

* Clean up Program parsers. #148

* Move into Language.CQL.Parser.Program.

* Simplify some of the stuff inside.

* Move QuickCheck generator for Parser into test dir. #148

* More cleanup. #148

* Segregate morphism code into Morphism.hs. #148

* Tighten imports from Morphism. #148

* Rename Morphism-related functions for clarity. #148

* Improve naming and qualification of Morphism-related functions. #148

* Move Collage into its own separate module. #148

* Fix typo in 'lower' doc comment. #148
epost added a commit that referenced this issue Aug 21, 2019
@epost
Move assembleGens from Instance into Collage. #148
468409e
epost added a commit that referenced this issue Aug 21, 2019
@epost
Move assembleGens from Instance into Collage. #148
9a113fe
epost added a commit that referenced this issue Aug 21, 2019
@epost
Move Presentation into its own module Instance.Presentation. #148
5b02e16
epost added a commit that referenced this issue Aug 21, 2019
@epost
Clean up code in and around Instance.Presentation. #148
ee41cb2
epost added a commit that referenced this issue Aug 21, 2019
@epost
Clean up code in and around Instance.Presentation. #148
0bc2291
epost added a commit that referenced this issue Aug 21, 2019
@epost
Assorted formatting, refactoring, commenting. #148
9777270
epost added a commit that referenced this issue Aug 21, 2019
@epost
Rename checkSatisfaction -> I.satisfiesSchema, typecheckPresentation …
afd992e 
…-> IP.typecheck. #148
epost added a commit that referenced this issue Aug 21, 2019
@epost
Rename checkSatisfaction -> I.satisfiesSchema, typecheckPresentation …
e3347fa 
…-> IP.typecheck. #148
epost added a commit that referenced this issue Aug 21, 2019
@epost
in Presentation, rename eqs0 to eqs and fully qualify as IP.eqs. #148
2aec6fb
epost added a commit that referenced this issue Aug 22, 2019
@epost
Move Algebra into its own module Instance.Algebra. #148
541a88c
epost added a commit that referenced this issue Aug 22, 2019
@epost
Move Algebra into its own module Instance.Algebra. #148
f6fa803
epost added a commit that referenced this issue Aug 22, 2019
@epost
Instance.hs: move satisfiesSchema down a bit. #148
3738b83
epost added a commit that referenced this issue Aug 22, 2019
@epost
Rename presToCol to IP.toCollage. #148
0f77a33
epost added a commit that referenced this issue Aug 22, 2019
@epost
Rename Term.simplifyFix to Term.simplifyTheory. #148
656001a
epost added a commit that referenced this issue Aug 22, 2019
@epost
Term.hs: Rename findSimplifiable -> findSimplifiableEqs. #148
6a92d8e
epost added a commit that referenced this issue Aug 22, 2019
@epost
Term.hs: Introduce Theory type alias. #148
0bce9fd
epost added a commit that referenced this issue Aug 22, 2019
@epost
Misc comments and formatting. #148
f882abd
epost added a commit that referenced this issue Aug 22, 2019
@epost
Misc comments and formatting. #148
a287861
epost added a commit that referenced this issue Aug 22, 2019
@epost
Instance.hs: Use Carrier type alias where it fits. #148
80a9a6b
epost added a commit that referenced this issue Aug 22, 2019
@epost
Clean up leftovers from moving Carrier and TalgGen into Algebra. #148
7e31026
epost added a commit that referenced this issue Aug 22, 2019
@epost
Term.hs: move Head directly under Term. #148
272aaa8
epost added a commit that referenced this issue Aug 22, 2019
@epost
Term.hs: rename replace' -> replace. #148
f6af11b
epost added a commit that referenced this issue Aug 22, 2019
@epost
Simplify and clean up findSimplifiableEq. #148
1fcb61b
epost added a commit that referenced this issue Aug 23, 2019
@epost
Simplify and clean up findSimplifiableEq. #148
8c507cf
epost added a commit that referenced this issue Aug 23, 2019
@epost
Still more Cleanup. #148 (#154)
f969b85 
* Move assembleGens from Instance into Collage. #148

* Move Presentation into its own module Instance.Presentation. #148

* Clean up code in and around Instance.Presentation. #148

* Assorted formatting, refactoring, commenting. #148

* Rename checkSatisfaction -> I.satisfiesSchema, typecheckPresentation -> IP.typecheck. #148

* in Presentation, rename eqs0 to eqs and fully qualify as IP.eqs. #148

* Move Algebra into its own module Instance.Algebra. #148

* Instance.hs: move satisfiesSchema down a bit. #148

* Rename presToCol to IP.toCollage. #148

* Remove duplicate simplifyAlg and rename to A.simplify. #148

* Rename Term.simplifyFix to Term.simplifyTheory. #148

* Term.hs: Rename findSimplifiable -> findSimplifiableEqs. #148

* Term.hs: Introduce Theory type alias. #148

* Misc comments and formatting. #148

* Instance.hs: Use Carrier type alias where it fits. #148

* Clean up leftovers from moving Carrier and TalgGen into Algebra. #148

* Term.hs: move Head directly under Term. #148

* Term.hs: rename replace' -> replace. #148

* Simplify and clean up findSimplifiableEq. #148
epost added a commit that referenced this issue Aug 23, 2019
@epost
Rename schToCol -> Schema.toCollage, and refactor. #148
cad5118
@epost epost pinned this issue Aug 23, 2019
epost added a commit that referenced this issue Aug 23, 2019
@epost
Reimplement EQ as a specialisation of underlying newtype EQF a = EQ (…
ffb6ef1 
…a, a). #148
@epost epost changed the title Cleanup Refactor & clean up Aug 23, 2019
epost added a commit that referenced this issue Aug 23, 2019
@epost
Replace uppEQ by (fmap upp). #148
93013e4
epost added a commit that referenced this issue Aug 23, 2019
@epost
Rearrange code in Term.hs. #148
046f082
epost added a commit that referenced this issue Aug 23, 2019
@epost
Rearrange code in Term.hs. #148
d96de15
epost added a commit that referenced this issue Aug 23, 2019
@epost
Rearrange code in Term.hs. #148
ebf7e5b
epost added a commit that referenced this issue Aug 23, 2019
@epost
Rearrange code in Term.hs. #148
4dca7a5
epost added a commit that referenced this issue Aug 23, 2019
@epost
Reimplement mapVar (was really a setter) as mapTermVar. #148
ce06b94
marcosh added a commit that referenced this issue Jan 21, 2020
@marcosh
[#148] small improvements
429a478
marcosh pushed a commit that referenced this issue Jan 21, 2020
@epost @marcosh
Rename schToCol -> Schema.toCollage, and refactor. #148
8c543f2
marcosh pushed a commit that referenced this issue Jan 21, 2020
@epost @marcosh
Reimplement EQ as a specialisation of underlying newtype EQF a = EQ (…
f5b8472 
…a, a). #148
marcosh pushed a commit that referenced this issue Jan 21, 2020
@epost @marcosh
Replace uppEQ by (fmap upp). #148
fc49f42
marcosh pushed a commit that referenced this issue Jan 21, 2020
@epost @marcosh
Rearrange code in Term.hs. #148
e58ca07
marcosh pushed a commit that referenced this issue Jan 21, 2020
@epost @marcosh
Reimplement mapVar (was really a setter) as mapTermVar. #148
d681402
marcosh added a commit that referenced this issue Jan 21, 2020
@marcosh
[#148] small improvements
cd8a8f9
marcosh added a commit that referenced this issue Jan 21, 2020
@marcosh
Merge pull request #155 from statebox/148/ever-more-cleanup
b155e73 
Ever more refactoring. #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epost epost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epost