Bugfix/remove shuffle #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! That We're also thinking that removing the shuffle only fixed this for you coincidentally, and that if there's a problem with a view leaking from one page to another, there's likely a more intentional fix required. Worth looking into, but going to close this one for now. Feel free to create an issue with steps to reproduce, or even a example repo, if possible ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shuffle function seems to cause index pages of paginated collections to randomly take the view of one of the later pages in the resultset.
It probably needs further digging to understand why the wrong page is being substituted, but simply removing the shuffle seems to solve it for now.