Improve Nova integration #3543
Merged
Improve Nova integration #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this change mean it would no longer be required to turn off Statamic's default routing? You'd just be able to leave it turned on? If so, major thanks! 🤝 |
|
Yeah exactly. |
Sweet! That'll save pain on new projects. |
|
With this regex, if you have a page like I can add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to use Nova with Statamic already - you can see how here: https://statamic.dev/knowledge-base/laravel-nova
This PR makes the integration just a little nicer, reducing those steps from 5 to 3.
statamic/ideas#238