Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add divider to gallery tab #3508

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

cj12312021
Copy link
Collaborator

@cj12312021 cj12312021 commented Mar 5, 2023

This pull request makes the gallery tab collapsable so gallery images can take up the full window width.

Uncollapsed:
Screenshot 2023-03-05 093707

Collapsed:
Screenshot 2023-03-05 094134

@cj12312021 cj12312021 added improvement Something needed tweaking. ui Issues related to UI labels Mar 5, 2023
@WithoutPants
Copy link
Collaborator

I think the image page divider is of pretty limited use. A better option would be to click the image to view it fullscreen. Gallery divider looks good.

@cj12312021
Copy link
Collaborator Author

Yeah, I questioned the practicality of the image divider after pushing that change. I'll remove it.

@WithoutPants WithoutPants added this to the Version 0.20.0 milestone Mar 6, 2023
@WithoutPants WithoutPants merged commit 42fde9b into stashapp:develop Mar 6, 2023
@JanJastrow
Copy link

Suggestion: also add the , shortcut to colapse/open it.

@cj12312021
Copy link
Collaborator Author

I can include that shortcut in #3514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking. ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants