Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for rtmros common test #879

Merged
merged 5 commits into from
Dec 16, 2015

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Dec 16, 2015

Update for rtmros common test.

@snozawa
Copy link
Contributor Author

snozawa commented Dec 16, 2015

Travis passed.

Fixed problems

@snozawa
Copy link
Contributor Author

snozawa commented Dec 16, 2015

Dirty workaround for test-samplerobot.test's hztest (#877 (comment))

Debug memo

I could reproduce too small hztest problem on my PCs.
I increased wait_time and test_duration, but problem not solved.

I doubted frequency of hrpsys-simulator or HrpsyseqStateROSBridge.
I added usleep to both of them (like usleep(10000)) and HrpsysSeqStateROSBridge [Hz] printing became small.
But, problem cannot be reproduced by this usleep.

snozawa added a commit that referenced this pull request Dec 16, 2015
@snozawa snozawa merged commit e31158c into start-jsk:master Dec 16, 2015
@snozawa snozawa deleted the update_for_rtmros_common_test branch December 16, 2015 12:19
@k-okada
Copy link
Member

k-okada commented Dec 16, 2015

On Wed, Dec 16, 2015 at 9:18 PM, Shunichi Nozawa [email protected]
wrote:

I added usleep to both of them (like usleep(10000)) and
HrpsysSeqStateROSBridge [Hz] printing became small.
But, problem cannot be reproduced by this usleep.

do you mean adding usleep decrease Hz messe, but it did not fail on hztest?

◉ Kei Okada

@snozawa
Copy link
Contributor Author

snozawa commented Dec 21, 2015

Sorry for late.

do you mean adding usleep decrease Hz messe, but it did not fail on hztest?

Yes.
[Hz] print message from HrpsysSeqStateROSBridge is real-time Hz, which is different from simulation-time's Hz.
Even if real-time Hz is slow, hztest succeeded because it seem to check clock's time originally derived from hrpsys-simulator.

@snozawa snozawa mentioned this pull request Dec 21, 2015
@k-okada
Copy link
Member

k-okada commented Dec 21, 2015

it is called 'Wall-Clock' (https://wiki.ros.org/Clock) and when you use
hrpsys-simulator, ros uses as same clock as hrpsys simuation cllock as
"simulaated clock", whcih was returnd by ros::Time::now()
And I think hz test checks on "simulated clock", sso adding sleep may not
work.

◉ Kei Okada

On Mon, Dec 21, 2015 at 2:09 PM, Shunichi Nozawa [email protected]
wrote:

Sorry for late.

do you mean adding usleep decrease Hz messe, but it did not fail on hztest?

Yes.
[Hz] print message from HrpsysSeqStateROSBridge is real-time Hz, which is
different from simulation-time's Hz.
Even if real-time Hz is slow, hztest succeeded because it seem to check
clock's time originally derived from hrpsys-simulator.


Reply to this email directly or view it on GitHub
#879 (comment)
.

@snozawa
Copy link
Contributor Author

snozawa commented Dec 21, 2015

it is called 'Wall-Clock' (https://wiki.ros.org/Clock) and when you use hrpsys-simulator, ros uses as same clock as hrpsys simuation cllock as "simulaated clock", whcih was returnd by ros::Time::now() And I think hz test checks on "simulated clock", sso adding sleep may not work.

Yes, I thought so.
So I wanted to confirm some kinds of slowness of hrpsys-simulator or HrpsysSeqStateROSBridge execution does not influence on hztest error thanks for Wall-Clock.
#879 (comment) shows hztest error is not derived from slowness of execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants