Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hrpsys_config.py in seq walking sample. #79

Merged
merged 3 commits into from
Apr 30, 2014

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Apr 20, 2014

Use hrpsys_config.py for creating RTCs, connecting of ports, and activation
according to discussion in
#65 (comment)

@snozawa snozawa mentioned this pull request Apr 20, 2014

# set path to hrpsys to get import rpy, see <hrpsys>/test/test-samplerobot.py for using HrpsysConfigurator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete line for catkin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are copied from hrpsys_tools_config.py:
https://github.com/start-jsk/rtmros_common/blob/master/hrpsys_tools/scripts/hrpsys_tools_config.py

I thought hrpsys_tools_config.py worked on both rosbuild and catkin.
Is this correct?

sensor_ros_bridge_connect.py has another way to import hrpsys_config.py.
https://github.com/start-jsk/rtmros_common/blob/master/hrpsys_ros_bridge/scripts/sensor_ros_bridge_connect.py

I'd like to know which is the best way to import hrpsys_config.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/start-jsk/rtmros_common/blob/9c30250a5df5793dd9df0b161fc7642835755b67/hrpsys_ros_bridge/scripts/hrpsys_dashboard is the good example of writing python code that works on both rosmake and catkin.

the example you mentioned had some trouble on same situation (sorry I can't point out but it actually have problem)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-okada
Copy link
Member

k-okada commented Apr 30, 2014

before merging this code, please review proposed process -> start-jsk/rtmros_common#449

@snozawa
Copy link
Contributor Author

snozawa commented Apr 30, 2014

I read start-jsk/rtmros_common#449.

Currently getRTCList is overwrote in samplerobot-walk.py.
I'll remove it if getRTCList returns stable RTCs.
fkanehiro/hrpsys-base#212

snozawa added a commit that referenced this pull request Apr 30, 2014
@snozawa snozawa merged commit 73a5ffa into start-jsk:master Apr 30, 2014
snozawa pushed a commit to snozawa/hrpsys that referenced this pull request Apr 30, 2014
@snozawa snozawa mentioned this pull request Apr 30, 2014
@snozawa snozawa deleted the use_hrpsys_config_for_seq_sample branch May 25, 2014 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants