Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dspy): Add tests to CI #458

Merged
merged 25 commits into from
Feb 27, 2024
Merged

ci(dspy): Add tests to CI #458

merged 25 commits into from
Feb 27, 2024

Conversation

isaacbmiller
Copy link
Collaborator

@isaacbmiller isaacbmiller commented Feb 26, 2024

  1. Create a new action to run the tests that @thomasahle implemented. Fix Bug: Unable to run tests locally #456
  2. Fix the pre-commit checks workflow
  3. Adjusted the pyproject.toml to have pytest as a dependency.

Note: databricks integration does not pass tests. Commented out as that is the only integration to do so. To be added back at a later date

@okhat
Copy link
Collaborator

okhat commented Feb 26, 2024

The databricks integration is very new so it doesn’t have users yet (merged today). Is unmerging it temporarily useful for this

@isaacbmiller
Copy link
Collaborator Author

Yes unmerging would unblock this

@isaacbmiller
Copy link
Collaborator Author

Also how do you feel about the pre-commit checks? A lot of the code isn't up to style, and it seems very strict. But this could be the start of actually requiring people's code to meet the style guide

@okhat
Copy link
Collaborator

okhat commented Feb 26, 2024

Imo let’s not worry about style checks just yet

@okhat
Copy link
Collaborator

okhat commented Feb 26, 2024

And 100% feel free to temporarily remove the databricks integration if you like. We’ll add it back soon

@okhat
Copy link
Collaborator

okhat commented Feb 26, 2024

I’d like to merge this when you think it’s ready! No rush though

@isaacbmiller
Copy link
Collaborator Author

Leaving databricks commented out but can also delete files

@okhat
Copy link
Collaborator

okhat commented Feb 26, 2024

Oh looks like import pydantic is failing here. Btw so far I've been relying on setup.py so it's very possible the *.toml is not completely correct, someone created it a while back and it may have some mistakes

@isaacbmiller
Copy link
Collaborator Author

Yeah weird i already manually added pydantic to the .toml file

@isaacbmiller isaacbmiller marked this pull request as ready for review February 26, 2024 06:31
@isaacbmiller
Copy link
Collaborator Author

Ready to merge whenever @okhat

We do have 3 different build systems currently and should probably get rid of 2 of them, but that can be further discussion

@isaacbmiller
Copy link
Collaborator Author

Wait don't merge setup.py is broken now

@isaacbmiller
Copy link
Collaborator Author

Ok we good now, setup.py build works

@insop
Copy link
Contributor

insop commented Feb 26, 2024

@isaacbmiller , this is great.
I did not go through databrick file since it is commented out, but others looks good to me.

@isaacbmiller
Copy link
Collaborator Author

@okhat I am locking pydantic dependency to 2.5.0 because there is a test that specifically relies on the version of pydantic. I would rather merge this than rewrite that test, so I will rewrite the test later

@isaacbmiller
Copy link
Collaborator Author

Hmmm github not adding in recent commits

@isaacbmiller
Copy link
Collaborator Author

Ready to merge

@isaacbmiller
Copy link
Collaborator Author

@okhat Can I merge?

@arnavsinghvi11
Copy link
Collaborator

Hi @isaacbmiller , I just patched the databricks.py file in this latest PR to move the OpenAI dependency within a local function. feel free to check it out if that passes the tests now so we can merge that alongside this PR!

@arnavsinghvi11
Copy link
Collaborator

Thanks @isaacbmiller ! ready to merge on @okhat 's go :)

@okhat
Copy link
Collaborator

okhat commented Feb 27, 2024

Ok running some checks!

@okhat
Copy link
Collaborator

okhat commented Feb 27, 2024

Unclear why the first test is failing... I tinkered with poetry but it didn't help

@okhat okhat merged commit 3b935d5 into main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to run tests locally
4 participants