Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Update YouRM to return an Iterable of Predictions #455

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

mgbvox
Copy link
Contributor

@mgbvox mgbvox commented Feb 25, 2024

This brings it in line with the behavior of other retriever implementations in /retrieve.

Related - we probably want to make dspy.Retrieve a Protocol or AbstractMethod so Pycharm and co can highlight/catch these errors ahead of time.

update you_rm to return an iterable of predictions, in line with othe…
@okhat
Copy link
Collaborator

okhat commented Feb 25, 2024

Thanks so much @mgbvox ! I agree we need an abstract interface. #424 is probably a good example (but for LMs)

@okhat okhat merged commit d90abb2 into stanfordnlp:main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants