🐛 fix: http_request_kwargs in HFClientVLLM #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge this but curious if it will break anything for @XenonMolecule or @arnavsinghvi11 , e.g. caches |
|
Thanks @MohammedAlhajji ! this won't break any existing caches but left a small comment to check out to ensure |
|
@arnavsinghvi11 Thanks for catching that. I squashed the commits and updated the PR |
|
Thanks @MohammedAlhajji ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into SSL certificate issues when connecting to our deployed model via the VLLM client.
I noticed HFClientTGI has this argument http_request_kwargs to be used in the generate step. Thought it would be helpful to add it to HFClientVLLM
Please let me know if any changes are needed. If this PR is not useful, please feel free to close it as well