Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: package name and version in setup.py and pyproject.toml #1205

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

hmoazam
Copy link
Collaborator

@hmoazam hmoazam commented Jun 25, 2024

Leave default values in project files for installation from source. Default values get replaced by automation by using comments as markers instead of placeholders.

@arnavsinghvi11 arnavsinghvi11 merged commit 57a69b8 into stanfordnlp:main Jun 25, 2024
5 checks passed
@arnavsinghvi11
Copy link
Collaborator

Thanks @hmoazam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants