Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated vLLM local client usage in docs markdown #1147

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

fivejjs
Copy link
Contributor

@fivejjs fivejjs commented Jun 14, 2024

The markdown lines change toward the issue: #1136

@arnavsinghvi11
Copy link
Collaborator

arnavsinghvi11 commented Jun 15, 2024

Hi @fivejjs ,

Thanks for this PR! I believe your method is actually a different way of prompting models through vLLM, using OpenAI SDK through DSPy instead of REST API to the vLLM port (which is how dspy.HFClientVLLM is set up right now). Instead of replacing the existing documentation on using dspy.HFClientVLLM, feel free to add a separate section on how to query the hosted vLLM model through OpenAI SDK under Sending requests to the server.

@fivejjs
Copy link
Contributor Author

fivejjs commented Jun 16, 2024

👍

@arnavsinghvi11
Copy link
Collaborator

Thanks @fivejjs ! made some minor edits and merged.

@arnavsinghvi11 arnavsinghvi11 merged commit 63f0a2b into stanfordnlp:main Jun 16, 2024
4 checks passed
arnavsinghvi11 added a commit that referenced this pull request Jul 12, 2024
updated vLLM local client usage in docs markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants