Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Prem Templates #1143

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Conversation

Anindyadeep
Copy link
Contributor

This PR adds an improvement to dsp.modules.prem.PremAI by introducing using Prem Prompt Templates throughout dspy calls.

@Anindyadeep Anindyadeep marked this pull request as draft June 13, 2024 12:38
@Anindyadeep Anindyadeep marked this pull request as ready for review June 14, 2024 07:49
@arnavsinghvi11
Copy link
Collaborator

Thanks @Anindyadeep ! left a minor comment and revised some of the documentation - should be good to merge after that!

@Anindyadeep
Copy link
Contributor Author

Thanks @Anindyadeep ! left a minor comment and revised some of the documentation - should be good to merge after that!

Yes you are right, so I added some latest changes addressing those. Additionally I combined the raw and all kwargs, just to remove redundancy.

@arnavsinghvi11 arnavsinghvi11 merged commit 6640cce into stanfordnlp:main Jun 17, 2024
4 checks passed
@arnavsinghvi11
Copy link
Collaborator

Thanks @Anindyadeep !

arnavsinghvi11 added a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants