refactor(inspect-history): Refactor providers #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to refactor redundant logic within the
dspy.LM.inspect_history
method.I came across this when trying to integrate a custom LLM —
inspect_history
expects a particular schema fromself.history[i]['requests']
that isn't documented in the docs. These if/else statements indicate a deficiency of the existing interface.I'm happy to extend in the interface across all
LM
subclasses, cleaning up the if/else statement here and update the docs. However, I would first like to understand what is the concept of "choices" inprinted.append("<prompt>", "<choices>")
, and possibly some guidance on the proper interface if you have any.Thanks!