Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentiment: Allow evaluation of external files #38

Closed
wants to merge 3 commits into from
Closed

Sentiment: Allow evaluation of external files #38

wants to merge 3 commits into from

Conversation

mhaas
Copy link

@mhaas mhaas commented Nov 25, 2014

I am testing some sentiment analysis in comparison to the RNTN. I would like to use the exact same code used by the RNTN for the evaluation. This pull request allows the use of external trees with predictions.

Michael Haas added 3 commits November 25, 2014 10:57
This commit adds a method to read a file with predicted sentiment
labels.

I release the changes proposed in this commit to the public domain
in accordance with the CONTRIBUTING.md document. -- Michael Haas
External predictions, if stored in PTB format, can now be
evaluated with the same code as the RNTN.

This commit refactors most of the original code into an
abstract class, AbstractEvaluate. Evaluate.java implements
the original functionality, so the change is fully compatible.
ExternalEvaluate.java implements the new functionality.

I release the changes proposed in this commit to the public domain
in accordance with the CONTRIBUTING.md document. --Michael Haas
@manning
Copy link
Member

manning commented Dec 21, 2014

Thanks for the contribution!

@manning manning closed this in 5e647f2 Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants