Ud2 updates #1445
Open
Ud2 updates #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngledLuffa
force-pushed
the
ud2_updates
branch
2 times, most recently
from
49c941a
to
fbe62ad
Compare
…the resulting dependencies both connect to day instead of from about -> a, changing the UD nummod to a det
…ut changing TreeGraphNode to print out the whole tree, but that would presumably mess up some various dependency outputs
…ke sure the XPOS tags get updated in the converter when using the PTB corrector
…ted trees for the structure of the UD graphs, not just the tags. Noticeably reduces the number of validator errors
gripes and complains both show up in PTB in terms of checking the results. most of the other verbs added do not
AngledLuffa
force-pushed
the
ud2_updates
branch
2 times, most recently
from
0c1ed1b
to
9e56520
Compare
actually, there's only one in PTB - Also excluded will be investments ...
…hat random hash ordering doesn't cause the graph to have a different output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to better match the new dependency scheme for list items, as done in UD2.14
Put the PTB Corrector earlier in the dependency conversion, making better use of its changes