Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user popover if mention inside link #1245

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Jun 22, 2024

User popovers showed "user not found" if users were mentioned within a markdown link.

I noticed this while writing this comment. I initially wrote this:

[@Natalia be like](https://stacker.news/items/549152):

![](https://m.stacker.news/36436)

but then I realized that it shows "user not found" because name was set to @Natalia be like.

This PR fixes that.

@ekzyis ekzyis added the bug label Jun 22, 2024
@huumn huumn merged commit 3f6581f into master Jun 23, 2024
6 checks passed
@huumn huumn deleted the fix-user-popover-mention-within-link branch June 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants