Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

633 event post type #1140

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

dillon-co
Copy link
Contributor

@dillon-co dillon-co commented May 2, 2024

Description

closes #633

Screenshots

Screenshot from 2024-05-06 19-21-08
Screenshot from 2024-05-06 19-20-45
Screenshot from 2024-05-06 19-20-32
Screenshot from 2024-05-06 19-19-23
Screenshot from 2024-05-06 19-11-44
Screenshot from 2024-06-27 11-25-00
Screenshot from 2024-06-27 11-24-45

Additional Context

New migration for enum was added

Checklist

Are your changes backwards compatible? Please answer below:

I believe so

Did you QA this? Could we deploy this straight to production? Please answer below:

I did QA this. Seemed to work correctly, but I added a lot of things. From my knowledge

For frontend changes: Tested on mobile? Please answer below:
Yes

Did you introduce any new environment variables? If so, call them out explicitly here:

No

@dillon-co dillon-co marked this pull request as ready for review May 7, 2024 00:34
Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

The recent updates introduce an 'EVENT' post type across the application, enabling users to create, update, and manage events with specific details like date and location. These changes span multiple files, from backend schemas and GraphQL type definitions to frontend components, ensuring a cohesive functionality for handling event data.

Changes

Files Summary
api/resolvers/item.js, api/typeDefs/item.js Added upsertEvent functionality and related schema updates for event handling.
components/event-form.js, components/item.js, components/post.js, components/recent-header.js, components/territory-form.js Enhanced UI components to support event creation, display, and management.
fragments/items.js, prisma/migrations/.../migration.sql, prisma/schema.prisma Database and GraphQL fragment updates to include event-specific fields.
lib/constants.js, lib/form.js, lib/validate.js Backend logic and validation for the new event type.

Assessment against linked issues

Objective Addressed Explanation
Support for event post type with time/date/location specifications (#633)
Displaying events in a calendar view if supported by the sub (#633) The current changes do not include functionality for a calendar view display.
Creation of communal calendars through event posts (#633) While the infrastructure for event posts has been set up, it's unclear if this translates directly to communal calendar functionality without additional context on how these events are shared or viewed collectively.

The current updates effectively lay down the groundwork for handling event-type posts with necessary attributes and operations. However, the extension to a communal calendar view and its interaction needs further development or clarification.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

components/recent-header.js Show resolved Hide resolved
@huumn
Copy link
Member

huumn commented May 12, 2024

At a quick glance, this creates the event post type but it doesn't create a calendar view. Without the calendar view

  1. this is only a difficulty:medium-hard
  2. doesn't have a reason to be merged (people can create discussion posts with date/time/location in the text)

Do you want to create the calendar view for it?

If yes, we can pop this into draft. If no, I can review but it won't be merged until someone does a calendar view for it.

@dillon-co
Copy link
Contributor Author

Yeah I can do a calendar view no prob.

Should it be a calendar view with all the events or just the single event?

@huumn
Copy link
Member

huumn commented May 12, 2024

It should have all the events. If I'm in home, all the events for the territories I view in home. If I'm in a territory, it should show all the events for that territory.

@huumn huumn marked this pull request as draft May 13, 2024 14:15
@dillon-co dillon-co marked this pull request as ready for review June 27, 2024 16:28
@huumn huumn marked this pull request as draft July 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event post type
2 participants