refactor theme bar, add extra param, add read from config option #22
Conversation
| @@ -7,7 +7,7 @@ module.exports = `<div id="theme-bar" class="theme-bar theme-bar-fixed theme-bar | |||
| <div class="theme-bar-center"> | |||
| {% if stackbit_banner.github_url %} | |||
| <a | |||
| class="theme-bar-button theme-bar-button-outlined theme-bar-fork" | |||
There was a problem hiding this comment.
theme-bar-fork class was added by me - as far as I remember, it can be removed
| newSiteLink.searchParams.set('theme', props.themeBarNewSiteTheme) | ||
| } | ||
|
|
||
| if (props.themeBarNewSiteParams) { |
There was a problem hiding this comment.
Amazing! So we can migrate from themeBarUserGroup. Please, ping me after releasing factory with this updated unibit version so I'll update the codebase
| themeBarNewSite: searchParams.get("themeBarNewSite"), | ||
| themeBarNewSiteLink: searchParams.get("themeBarNewSiteLink"), | ||
| themeBarNewSiteTheme: searchParams.get("themeBarNewSiteTheme"), | ||
| themeBarUserGroup: searchParams.get("themeBarUserGroup") |
There was a problem hiding this comment.
@JugglerX @VitaliyR please rename this field to something else.
For my understanding, it is needed for an extra parameter like userGroup=nocode.
If this is the case please provide different parameter like: url_params=${encodeUrlComponent('userGroup=nocode')}
The idea is not to have parameter names specific to stackbit internal features as this is an open-source project.
There was a problem hiding this comment.
removed. this is now handled by themeBarNewSiteLinkParams or can be set in the config (which is even better)
Adds support for the additional url params in theme bar
new URL Params supported.
Also adds support to read config from
https://themes.stackbit.com/themeBarConfig.js- so instead of having to really ugly url likehttp:https://themes.stackbit.com/demos/exto/?themeBarNewSite=Get Started&themeBarNewSiteLink=https://app.stackbit.com/create&themeBarNewSiteTheme=https://github.com/stackbit-themes/stackbit-starter-hugoyou could usehttp:https://themes.stackbit.com/demos/exto?demo=jstStarterHugowhich will read from thethemeBarConfig.jsby keyAlso refactored the vanilla js to something more manageable