Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behaviour of ignore_download_error to false #11

Closed
rhtenhove opened this issue Aug 1, 2019 · 1 comment
Closed

Change default behaviour of ignore_download_error to false #11

rhtenhove opened this issue Aug 1, 2019 · 1 comment
Assignees

Comments

@rhtenhove
Copy link

The default behaviour is to ignore download errors. In my (quite regular) setup this causes adsorber to not apply anything, because it runs at system startup with systemd, and the wifi doesn't connect that fast.
This results in an empty hosts file, and thus nothing gets blocked except for what's on the blacklist.

When setting ignore_download_error=false in /usr/local/etc/adsorber/adsorber.conf, it still proceeds after a download error when running adsorber update. So it seems the setting is ignored either way.

@stablestud
Copy link
Owner

Hello rhtenhove,

Thanks for reporting!

Sorry for being late, been on vacation.

I could reproduce your issue, im onto fixing it.
Also I will change the default ignore_download_error to false as you suggested, because it makes more sense actually.

Cheers
stablestud

@stablestud stablestud self-assigned this Aug 6, 2019
stablestud added a commit that referenced this issue Aug 6, 2019
The default value of 'ignore_download_error' is now 'false'
as suggested by #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants