Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Not scroll back to top after review #971

Merged
merged 3 commits into from
Jul 20, 2024
Merged

[FIX] Not scroll back to top after review #971

merged 3 commits into from
Jul 20, 2024

Conversation

4Source
Copy link
Contributor

@4Source 4Source commented May 24, 2024 •
edited
Loading

Fixes #966

Scroll back after review card done. Required for longer cards or small screens.

@ronzulu ronzulu added the beta Included in beta release, https://github.com/st3v3nmw/obsidian-spaced-repetition/discussions/1011 label Jul 16, 2024
ronzulu added a commit to ronzulu/obsidian-spaced-repetition that referenced this pull request Jul 16, 2024
@ronzulu
[FIX] Not scroll back to top after review
a770393 
st3v3nmw#971
Squashed commit 7e568fb
@st3v3nmw st3v3nmw merged commit 3024264 into st3v3nmw:master Jul 20, 2024
1 check passed
@4Source 4Source deleted the bug_966 branch July 20, 2024 08:17
KyleKlus pushed a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@4Source @KyleKlus
[FIX] Not scroll back to top after review (st3v3nmw#971)
213ba0b 
* Update deprecated function

* Add scroll back to top

* Fix linting
KyleKlus pushed a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@4Source @KyleKlus
[FIX] Not scroll back to top after review (st3v3nmw#971)
1fb55ae 
* Update deprecated function

* Add scroll back to top

* Fix linting
KyleKlus added a commit to KyleKlus/obsidian-spaced-repetition that referenced this pull request Jul 22, 2024
@KyleKlus
Squashed commit of the following:
eabfb01 
commit 971e4af
Author: Anna Zubenko <[email protected]>
Date:   Mon Jul 22 07:29:18 2024 +0200

    FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998)

commit a89a818
Author: 4Source <[email protected]>
Date:   Mon Jul 22 07:25:45 2024 +0200

    [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970)

    * Use obsidians funtion to extractFrontmatter

    * Fix line pos shift

    * Stop using obsidian function because of UnitTest

    * Add UnitTest for Frontmatter and Horizontal line

    * Fix linting

    ---------

    Co-authored-by: Stephen Mwangi <[email protected]>

commit 77f15e1
Author: Carlos Galdino <[email protected]>
Date:   Mon Jul 22 06:02:11 2024 +0100

    Filter due notes when all are scheduled (st3v3nmw#947)

    Ignore notes due in the future.

    Fixes st3v3nmw#548

commit 83590be
Author: Newdea <[email protected]>
Date:   Sat Jul 20 15:10:57 2024 +0800

    fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001)

commit e3a0146
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:02:14 2024 +0200

    [FIX] Include link parsing for Review context (st3v3nmw#964)

    * Include link parsing

    * Fix linting

commit 3024264
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:00:46 2024 +0200

    [FIX] Not scroll back to top after review (st3v3nmw#971)

    * Update deprecated function

    * Add scroll back to top

    * Fix linting

commit 1dfd52e
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:00:33 2024 +0200

    [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972)

    * Implement isEqualOrSubPath

    * Implement UnitTest for isEqualOrSubPath

    * Replace separators with system seperator

    * Improved seperator replacement

commit b175d22
Author: artificialUsagi <[email protected]>
Date:   Sat Jul 20 14:59:11 2024 +0800

    add translation: zh-cn (st3v3nmw#982)

commit ca4c261
Author: 4Source <[email protected]>
Date:   Sat May 25 10:13:50 2024 +0200

    Improved issue templates (st3v3nmw#963)

    * Replace bug_report with form instead of template

    * Replace feature_request with form instead of template

    * Fix linting

commit 053da6a
Author: 4Source <[email protected]>
Date:   Fri May 24 19:59:06 2024 +0200

    Update German localization (st3v3nmw#961)

    * Update German localization

    * Fix linting
ronzulu added a commit to ronzulu/obsidian-spaced-repetition that referenced this pull request Jul 24, 2024
@ronzulu
Squashed commit of the following:
fff77c5 
commit 3228e9c
Author: Ronny Zulaikha <[email protected]>
Date:   Wed Jul 24 15:10:39 2024 +1000

    Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935)

    * Nearly completed

    * Added RTL support for flashcards edit modal

    * Changes as part of the merge

    * post upstream master merge fixes

    * Minor code improvement

    * lint and format

    * Change log and documentation update

    * Minor code change

    * Fixed EditModal RTL

    * lint and format

    * Updated test cases to fix global coverage error

    * Format & lint

commit 971e4af
Author: Anna Zubenko <[email protected]>
Date:   Mon Jul 22 07:29:18 2024 +0200

    FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998)

commit a89a818
Author: 4Source <[email protected]>
Date:   Mon Jul 22 07:25:45 2024 +0200

    [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970)

    * Use obsidians funtion to extractFrontmatter

    * Fix line pos shift

    * Stop using obsidian function because of UnitTest

    * Add UnitTest for Frontmatter and Horizontal line

    * Fix linting

    ---------

    Co-authored-by: Stephen Mwangi <[email protected]>

commit 77f15e1
Author: Carlos Galdino <[email protected]>
Date:   Mon Jul 22 06:02:11 2024 +0100

    Filter due notes when all are scheduled (st3v3nmw#947)

    Ignore notes due in the future.

    Fixes st3v3nmw#548

commit 83590be
Author: Newdea <[email protected]>
Date:   Sat Jul 20 15:10:57 2024 +0800

    fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001)

commit e3a0146
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:02:14 2024 +0200

    [FIX] Include link parsing for Review context (st3v3nmw#964)

    * Include link parsing

    * Fix linting

commit 3024264
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:00:46 2024 +0200

    [FIX] Not scroll back to top after review (st3v3nmw#971)

    * Update deprecated function

    * Add scroll back to top

    * Fix linting

commit 1dfd52e
Author: 4Source <[email protected]>
Date:   Sat Jul 20 09:00:33 2024 +0200

    [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972)

    * Implement isEqualOrSubPath

    * Implement UnitTest for isEqualOrSubPath

    * Replace separators with system seperator

    * Improved seperator replacement

commit b175d22
Author: artificialUsagi <[email protected]>
Date:   Sat Jul 20 14:59:11 2024 +0800

    add translation: zh-cn (st3v3nmw#982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronzulu ronzulu ronzulu approved these changes

Assignees
No one assigned
Labels
beta Included in beta release, https://github.com/st3v3nmw/obsidian-spaced-repetition/discussions/1011
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Do not auto scroll to the top of the flashcard after clicking to reveal the answer
3 participants
@4Source @ronzulu @st3v3nmw