-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(git hook): add precommit-hook to handle validation checks #903
Conversation
9f9b905
to
e3f7ed3
Compare
Hi @EspiraMarvin does this mean that the lint/test operations will occur whenever a developer pushes local commits to GitHub. I.e. these operations will occur regardless of whether or not there is an associated PR? Thanks |
@ronzulu Yes, according to the PR, the operations will run regardless of whether or not there is an associated PR. |
Thanks. I think this is really helpful. |
@EspiraMarvin 👀 ... |
- add precommit hook to format, lint and test
e3f7ed3
to
3051169
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
- Coverage 93.16% 92.96% -0.20%
==========================================
Files 42 42
Lines 4537 4537
Branches 644 371 -273
==========================================
- Hits 4227 4218 -9
- Misses 308 317 +9
Partials 2 2 ☔ View full report in Codecov by Sentry. |
@st3v3nmw this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes #880