-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation for test class is too strict #66
Comments
mduft
added a commit
that referenced
this issue
Jun 27, 2022
Don't check test methods to be public - fixes #66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The validation looks for test related annotations on public test methods only. However, JUnit 5 no longer requires public test methods, therefore the validation wrongly fails on JUnit 5 test classes that leave away the public keyword.
See https://github.com/ssi-schaefer/lcdsl/blob/master/com.wamas.ide.launching/src/com/wamas/ide/launching/validation/LcDslValidator.xtend#L425 and https://github.com/ssi-schaefer/lcdsl/blob/master/com.wamas.ide.launching/src/com/wamas/ide/launching/validation/LcDslValidator.xtend#L427
The text was updated successfully, but these errors were encountered: