Skip to content

Commit

Permalink
Banning whitelist from dev vocabulary. cf rails/rails#33677
Browse files Browse the repository at this point in the history
  • Loading branch information
ssaunier committed Aug 22, 2018
1 parent b920a81 commit 6c925fe
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/github_webhook/processor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class UnsupportedContentTypeError < StandardError; end
# }
# });
# console.log(events);
GITHUB_EVENTS_WHITELIST = %w(
GITHUB_EVENTS = %w(

This comment has been minimized.

Copy link
@jgomo3

jgomo3 Jun 14, 2020

The terms "events" and "events white list" doesn't convey the same amount of information. By removing "white list" without a replacement, you are losing some intention explanation.

This could have been "events accepted list".

But, if this loss of information was considered during the change, then you this comment can be disregarded.

commit_comment
create
delete
Expand Down Expand Up @@ -94,7 +94,7 @@ def authenticate_github_request!
end

def check_github_event!
unless GITHUB_EVENTS_WHITELIST.include?(request.headers['X-GitHub-Event'])
unless GITHUB_EVENTS.include?(request.headers['X-GitHub-Event'])
raise UnsupportedGithubEventError.new("#{request.headers['X-GitHub-Event']} is not a whiltelisted GitHub event. See https://developer.github.com/v3/activity/events/types/")
end
end
Expand Down

0 comments on commit 6c925fe

Please sign in to comment.