Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken shebangs in dns_scripts and update README.md to include RPM and DEB package downloads, installation, and package building #778

Merged
merged 10 commits into from
Oct 26, 2022

Conversation

jeffmerkey
Copy link
Contributor

@jeffmerkey jeffmerkey commented Oct 8, 2022

Two of the dns scripts have invalid shebang defines in the top of file which causes downstream breakage during rpm install.
During build rpmbuild will add the shebangs (in this case "/usr/usr/bin/env) as a dependency and will break the install of the rpm file since '/usr/usr/bin/env' doesn't exist. RPM normally reads shebangs and adds them to a table of dependencies. This coding error looks to be just a typo of some sort. The malbehavior is that:

rpm -i getssl-2.47.noarch.rpm (install rpm)

will fail with errors because it cannot find '/usr/usr/bin/env' installed on the target system. The error returned is "/usr/usr/bin/env" dependency not found" during install.

This bug was introduced from this commit => 40e5084

The pull request fixes this problem and I have tested it on target systems.

I also have updated the README.md to include instructions on installing and building RPM and DEB packages for getssl and I also have a prebuilt release section in my fork which allows folks to download the RPM and DEB packages directly from github as release assets. You are more than welcome to copy and host the RPM and DEB packages on your release page instead of mine. I will be building RPM and DEB packages for your release regularly (each time you post a release).

I currently have a release page at https://github.com/jeffmerkey/getssl/releases which has the pre-compiled packages. Feel free to change the releases location in the README.md if you choose to host the packages with each of your releases.

Also, I have posted the getssl RPM and DEB files in a Yum, Deb, and Zypper repository at https://repo.icapsql.com that I currently maintain for the C-ICAP Project.. Please see https://github.com/jeffmerkey/icapsql-release for the rpm needed to activate the repository locally on your linux platform. At present, folks can use DNF and YUM to install getssl on Red Hat, CentOS, SuSe, AWS Linux, and Oracle Linux platforms from this repository. The repository is a work in progress and I am still adding modules and meta files for all the major Linux distros.

Also, the https://github.com/jeffmerkey/icapsql-debian-release *.deb package enables "apt" and "apt-get" repositories to download and install getssl packages for Debian and Ubuntu platforms.

Signed-off-by: jeffmerkey [email protected]

@jeffmerkey jeffmerkey changed the title fix broken shebangs in dns_scripts fix broken shebangs in dns_scripts and update README.md to include RPM and DEB package downloads, installati… …on, and package building Oct 13, 2022
@jeffmerkey jeffmerkey changed the title fix broken shebangs in dns_scripts and update README.md to include RPM and DEB package downloads, installati… …on, and package building fix broken shebangs in dns_scripts and update README.md to include RPM and DEB package downloads, installation, and package building Oct 13, 2022
@timkimber
Copy link
Member

Hi @jeffmerkey

Thanks for fixing these, I obviously didn't notice when I merged in the ionos changes.

I'll leave the releases pointing to your github at the moment, but will add an issue to auto-build rpm and deb packages when I do a release (which is well overdue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants