fix broken shebangs in dns_scripts and update README.md to include RPM and DEB package downloads, installation, and package building #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the dns scripts have invalid shebang defines in the top of file which causes downstream breakage during rpm install.
During build rpmbuild will add the shebangs (in this case "/usr/usr/bin/env) as a dependency and will break the install of the rpm file since '/usr/usr/bin/env' doesn't exist. RPM normally reads shebangs and adds them to a table of dependencies. This coding error looks to be just a typo of some sort. The malbehavior is that:
rpm -i getssl-2.47.noarch.rpm (install rpm)
will fail with errors because it cannot find '/usr/usr/bin/env' installed on the target system. The error returned is "/usr/usr/bin/env" dependency not found" during install.
This bug was introduced from this commit => 40e5084
The pull request fixes this problem and I have tested it on target systems.
I also have updated the README.md to include instructions on installing and building RPM and DEB packages for getssl and I also have a prebuilt release section in my fork which allows folks to download the RPM and DEB packages directly from github as release assets. You are more than welcome to copy and host the RPM and DEB packages on your release page instead of mine. I will be building RPM and DEB packages for your release regularly (each time you post a release).
I currently have a release page at https://github.com/jeffmerkey/getssl/releases which has the pre-compiled packages. Feel free to change the releases location in the README.md if you choose to host the packages with each of your releases.
Also, I have posted the getssl RPM and DEB files in a Yum, Deb, and Zypper repository at https://repo.icapsql.com that I currently maintain for the C-ICAP Project.. Please see https://github.com/jeffmerkey/icapsql-release for the rpm needed to activate the repository locally on your linux platform. At present, folks can use DNF and YUM to install getssl on Red Hat, CentOS, SuSe, AWS Linux, and Oracle Linux platforms from this repository. The repository is a work in progress and I am still adding modules and meta files for all the major Linux distros.
Also, the https://github.com/jeffmerkey/icapsql-debian-release *.deb package enables "apt" and "apt-get" repositories to download and install getssl packages for Debian and Ubuntu platforms.
Signed-off-by: jeffmerkey [email protected]