-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2.43 to 2.44 deletes getssl-script! #718
Comments
Hi @uklatt Really sorry that happened to you, we changed the upgrade function in the last release but I tried to make sure it wouldn't break! I cannot reproduce locally
Sorry again that this has broken for you |
Same thing happened to me when running getssl -u . The newly installed getssl had one line in it: 400 Bad Request Sounds like some wget or curl gone wrong. Here's my uname -a: Edit: A more recent version (v2.44) than 2.43 of getssl is available, please update Release v2.44 summary Check all certificates |
Here's the getssl -d -u command: detected os type = linux Running Amazon Linux AMI release 2018.03 checking for required which ... /usr/bin/which checking for required openssl ... /usr/bin/openssl checking for required curl ... /usr/bin/curl checking for dig ... /usr/bin/dig function dig found at /usr/bin/dig - setting DNS_CHECK_FUNC to dig checking for required dirname ... /usr/bin/dirname checking for required awk ... /bin/awk checking for required tr ... /usr/bin/tr checking for required date ... /bin/date checking for required grep ... /bin/grep checking for required sed ... /bin/sed checking for required sort ... /bin/sort checking for required sort ... /bin/sort checking for required mktemp ... /bin/mktemp Checking for releases at https://api.github.com/repos/srvrco/getssl/releases/latest {^M current code is version 2.43 Most recent version is 2.44 curl --silent --user-agent getssl/2.43 https://raw.githubusercontent.com/srvrco/v2.44/getssl --output /tmp/tmp.TK4OJkNJmn Updates are: Installed v2.44, restarting with /root/bin/getssl --nocheck -d Traceback main() line 2829 called check_getssl_upgrade() line 873 called error_exit() line 1233 called traceback |
After a little investigating here's the problem child. Try to open it: |
Yes it looks like the URL is wrong or there is no file... Uwe |
I had the same problem. There are two fixes that should be done (in reverse order!):
Point 2 is urgent, because such installations will cease to work without manual intervention! |
Same problem here. curl output
|
Thanks @fmondini , @uwedisch , @PostholerCom and @uklatt I'd already fixed locally which is why I couldn't reproduce! I've added sanity check code to prevent a bad update from being installed and am just quickly testing locally before I push a new version |
Add pre and post upgrade sanity checks Fixes #718
Hello,
today I updated getssl 2.43 to 2.44.
After executing the command "./getssl -u" the getssl file was overwritten!
The content of getssl is:
Is there a problem with version 2.43?
Uwe
The text was updated successfully, but these errors were encountered: