Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a message response for SendMessage and add UpdateMessage #17

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

42wim
Copy link
Contributor

@42wim 42wim commented Aug 28, 2017

This patch contains #16 and also changes the SendMessage method to return a Message.
So that we can get the message ID of the new message we have created (which can be used with UpdateMessage for example)

I've made 2 PR's because I'm not sure if you want to change this method signature

@sromku
Copy link
Owner

sromku commented Aug 28, 2017

It's a great addition @42wim 👍 . It's also fine to change the methods if it makes sense. The code looks good to me. Merged ✨ . Much thanks!

@sromku sromku merged commit 70f7030 into sromku:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants