Skip to content

Commit

Permalink
tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior (t…
Browse files Browse the repository at this point in the history
…ikv#7709)

Signed-off-by: Brian Anderson <[email protected]>
  • Loading branch information
brson authored and sre-bot committed Apr 30, 2020
1 parent 049a066 commit 0c4461e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
)?;
}

let buffer_ptr = (&*self.group_key_buffer).into();
for logical_row_idx in 0..logical_rows_len {
let offset_begin = self.group_key_buffer.len();

Expand Down Expand Up @@ -363,6 +362,7 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
}
}

let buffer_ptr = (&*self.group_key_buffer).into();
// Extra column is not included in `GroupKeyRefUnsafe` to avoid being aggr on.
let group_key_ref_unsafe = GroupKeyRefUnsafe {
buffer_ptr,
Expand Down

0 comments on commit 0c4461e

Please sign in to comment.