Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests for invocation scripts (squeak.{bat,sh}) #27

Open
LinqLover opened this issue Mar 3, 2022 · 0 comments
Open

Acceptance tests for invocation scripts (squeak.{bat,sh}) #27

LinqLover opened this issue Mar 3, 2022 · 0 comments

Comments

@LinqLover
Copy link
Contributor

Should we have some simple acceptance tests for this wouldn't this be worth the effort at the current stage?

Maybe also open an issue for this.

Originally posted by @marceltaeumel in #25 (comment)
LinqLover added a commit to LinqLover/squeak-app that referenced this issue Apr 27, 2022
@LinqLover
linux: Fix handling of spaces in squeak.sh args
9041c9d 
Do not split up command line arguments with spaces by using a bash array instead of concatenated string.

Fixes squeak-smalltalk#28. Still, proper tests are missing - better send me a few other scenarios before merging this patch, or try them out yourself. See also squeak-smalltalk#27.
@LinqLover LinqLover mentioned this issue Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LinqLover