Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pt. 2: Bump coroutines to 1.6.1 #723

Closed
wants to merge 3 commits into from

Conversation

bnvinay92
Copy link
Contributor

No description provided.

@bnvinay92 bnvinay92 force-pushed the vn/bump-to-native-coroutines branch from d388706 to b246f3b Compare April 13, 2022 19:35
@bnvinay92 bnvinay92 requested a review from a team as a code owner April 13, 2022 19:35
@RBusarow
Copy link
Member

Is there a specific reason to make this update now, like a transitive dependency causing a version conflict?

And did we have a specific reason for using the native-mt version?

@bnvinay92
Copy link
Contributor Author

bnvinay92 commented Apr 13, 2022

Is there a specific reason to make this update now, like a transitive dependency causing a version conflict?

And did we have a specific reason for using the native-mt version?

This and okio (bumped here #721) are external dependencies stopping :workflow-core from being published as a kmp library. This is the primary reason.

@ahmedre
Copy link

ahmedre commented Apr 14, 2022

I believe native-mt is deprecated in favor of the vanilla coroutines package due to the new memory model - via here:

1.6.0-native-mt has been released.

1.6.x will be the last series of native-mt releases and we are effectively decommissioning native-mt in the favour of the new memory model that is supported out-of-the-box in 1.6.0 coroutines release.

Coroutines 1.7.0 will be released without native-mt companion and we are gradually stopping the support of native-mt during the course of 1.6.x lifecycle. We still are ready to accept PRs or release versions with the new Kotlin if there is a need to, but new coroutine features won't get native-mt support.

@bnvinay92 bnvinay92 changed the title Bump coroutines to 1.6.1-native-mt Bump coroutines to 1.6.1 Apr 21, 2022
@bnvinay92 bnvinay92 force-pushed the vn/bump-to-native-coroutines branch from 88812d2 to 4b493ba Compare April 22, 2022 09:51
@bnvinay92 bnvinay92 changed the title Bump coroutines to 1.6.1 Pt2. Bump coroutines to 1.6.1 Apr 22, 2022
@bnvinay92 bnvinay92 changed the title Pt2. Bump coroutines to 1.6.1 Pt. 2: Bump coroutines to 1.6.1 Apr 22, 2022
@bnvinay92 bnvinay92 force-pushed the vn/bump-to-native-coroutines branch from 4b493ba to 63733cc Compare April 24, 2022 14:59
@bnvinay92 bnvinay92 force-pushed the vn/bump-to-native-coroutines branch from 63733cc to bb60377 Compare April 25, 2022 18:33
@bnvinay92 bnvinay92 closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants