Use Timeout.NONE for plain streams to avoid throwing InterruptedIOExcept... #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption The default Timeout implementation throws InterruptedIOException from throwIfReached when the current thread is interrupted.
|
I don't think it makes sense to permit user-defined timeouts on streams. Thread interruption isn't a scalpel; it's a cleaver! If you use it you don't get precision on where its detected or used. (There are many many other APIs with similar, unconfigurable behavior; all of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ion
The default Timeout implementation throws InterruptedIOException from
throwIfReached when the current thread is interrupted.
This closes #76.