Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-windows action fails during clean #1286

Closed
swankjesse opened this issue Jul 7, 2023 · 5 comments · Fixed by #1287
Closed

publish-windows action fails during clean #1286

swankjesse opened this issue Jul 7, 2023 · 5 comments · Fixed by #1287

Comments

@swankjesse
Copy link
Member

Our publish task for Okio 3.4.0 on Windows failed like so:

> Task :okio:clean FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':okio:clean'.
> java.io.IOException: Unable to delete directory 'D:\a\okio\okio\okio\build'
    Failed to delete some children. This might happen because a process has files open or has its working directory set in the target directory.
    - D:\a\okio\okio\okio\build\tmp\.cache\expanded\expanded.lock
    - D:\a\okio\okio\okio\build\tmp\.cache\expanded
    - D:\a\okio\okio\okio\build\tmp\.cache
    - D:\a\okio\okio\okio\build\tmp

I worked around it for 3.4.0 by skipping the clean task. But we should do something better here.

@JakeWharton
Copy link
Member

Can probably delete the whole job. Mac OS and Linux can both cross-compile for Windows targets for at least a year now.

If you look at the publish job it built and uploaded the mingw artifacts: https://github.com/square/okio/actions/runs/5486897376/jobs/9999698018

@swankjesse
Copy link
Member Author

Neato!

> Task :okio:publishMingwX64PublicationToMavenCentralRepository

@swankjesse
Copy link
Member Author

... and now I’m curious how both publishes succeeded. Don’t love that.

> Task :okio-fakefilesystem:signMingwX64Publication
> Task :okio-fakefilesystem:publishMingwX64PublicationToMavenCentralRepository
Closing repository: comsquareup-1278

? waiting for close...
? waiting for close...
? waiting for close...Repository comsquareup-1278 closed
Releasing repository: comsquareup-1278
Repository comsquareup-1278 released

@oldergod
Copy link
Member

oldergod commented Jul 8, 2023

Don't we wanna keep CI on windows to confirm environment related bugs, like the separator?

@swankjesse
Copy link
Member Author

Yes, good call. Only interested in dropping the publish-windows task.

swankjesse added a commit that referenced this issue Jul 8, 2023
It's no longer necessary.

Closes: #1286
swankjesse added a commit that referenced this issue Jul 8, 2023
It's no longer necessary.

Closes: #1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants