Adopt Version Catalog and Updates plugin #7075
Conversation
yschimke
added
android
build.gradle.kts
Outdated
| @@ -89,28 +94,29 @@ subprojects { | |||
|
|
|||
| val checkstyleConfig: Configuration by configurations.creating | |||
| dependencies { | |||
| checkstyleConfig(Dependencies.checkStyle) { | |||
| checkstyleConfig("com.puppycrawl.tools:checkstyle:9.2") { | |||
There was a problem hiding this comment.
Can move into an afterEvaluate to support?
There was a problem hiding this comment.
Yep.
afterEvaluate {
val checkstyleConfig: Configuration by configurations.creating
dependencies {
checkstyleConfig(libs.checkStyle) {
isTransitive = false
}
}
...
}
| classpath(libs.gradleplugin.benmanes.versions) | ||
| classpath(libs.gradleplugin.littlerobots.vcu) |
There was a problem hiding this comment.
Suggest removing these 2 plugins after migration.
There was a problem hiding this comment.
Why? They simplify the update process. For me this is more valuable than just refactoring our dependency files.
There was a problem hiding this comment.
Once you finish the migration, the littlerobots.vcu is less helpful, if you want to check updates, using a Gradle init script might be a better solution; if you want to update automatically, can use renovate.
There was a problem hiding this comment.
Is there a good sample of the former? It appears to have the same effect, but requires editing files that we currently currently .gitignore.
There was a problem hiding this comment.
We're doing renovate on cashapp org. It's... fine. Will hold us over until dependabot decides to wake up and actually support other ecosystems.
There was a problem hiding this comment.
Is there a good sample of the former? It appears to have the same effect, but requires editing files that we currently currently .gitignore.
There was a problem hiding this comment.
OK, I'll remove the plugins, and wait for someone in Block to configure for this repo.
I can see them coming through now https://github.com/yschimke/okhttp/pulls
There was a problem hiding this comment.
Involuntary shudder reading "someone at Block"... 🤮
There was a problem hiding this comment.
@yschimke Missed removing this?
There was a problem hiding this comment.
Yep - fixed here https://github.com/square/okhttp/pull/7081/files
In progress, but validating it works and simplifies routine updates.
Updating to releases would be with