Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #6806

Merged
merged 10 commits into from
Aug 2, 2021
Merged

Update dependencies #6806

merged 10 commits into from
Aug 2, 2021

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Aug 1, 2021

No description provided.

@yschimke yschimke added android Relates to usage specifically on Android jdk8 labels Aug 1, 2021
@Goooler
Copy link
Contributor Author

Goooler commented Aug 1, 2021

TaskRunnerTest > cancelReturnsTruePreventsNextExecution() FAILED
    java.lang.AssertionError: 
    Expecting actual:
      ["FINE: Q10001 finished run in 506 ms: MockWebServer /127.0.0.1:50750",
        "FINE: Q10000 scheduled after 100 µs: task",
        "FINE: Q10000 canceled              : task"]
    to contain exactly (and in same order):
      ["FINE: Q10000 scheduled after 100 µs: task",
        "FINE: Q10000 canceled              : task"]
    but some elements were not expected:
      ["FINE: Q10001 finished run in 506 ms: MockWebServer /127.0.0.1:50750"]
        at okhttp3.internal.concurrent.TaskRunnerTest.cancelReturnsTruePreventsNextExecution(TaskRunnerTest.kt:184)

@Goooler
Copy link
Contributor Author

Goooler commented Aug 1, 2021

@yschimke Should add graal label aslo.

@yschimke yschimke added the graal GraalVM related label Aug 1, 2021
@yschimke
Copy link
Collaborator

yschimke commented Aug 1, 2021

TaskRunnerTest > cancelReturnsTruePreventsNextExecution() FAILED

This test hooks into the JUL logging framework (which is awkwardly a JVM singleton) and it seems like an existing test is overrunning, producing overlapping events. Seems unrelated to your change.

@Goooler
Copy link
Contributor Author

Goooler commented Aug 1, 2021

TaskRunnerTest > cancelReturnsTruePreventsNextExecution() FAILED

This test hooks into the JUL logging framework (which is awkwardly a JVM singleton) and it seems like an existing test is overrunning, producing overlapping events. Seems unrelated to your change.

Ok.

@yschimke yschimke removed the openjsse label Aug 1, 2021
@Goooler
Copy link
Contributor Author

Goooler commented Aug 1, 2021

The following dependencies have later milestone versions:

May I'll bump them in separated PRs.

@Goooler
Copy link
Contributor Author

Goooler commented Aug 1, 2021

And maven repos declared in settings.gradle.kts could be removed as they also appear in buildscript and allprojects.

image

@yschimke
Copy link
Collaborator

yschimke commented Aug 2, 2021

The following dependencies have later milestone versions:

* org.apache.httpcomponents.client5:httpclient5 [5.0 -> 5.1]
  https://hc.apache.org/httpcomponents-client-5.0.x/

* org.jetbrains.dokka:dokka-gradle-plugin [0.10.1 -> 1.5.0]
  https://github.com/Kotlin/dokka

* org.jsoup:jsoup [1.13.1 -> 1.14.1]
  https://jsoup.org/

May I'll bump them in separated PRs.

Dokka is problematic, and the other two are not something we require. We don't need to take every minor bump of these peripheral libraries. Generally we'd take most version of something like Kotlin or Gradle. We would definitely take every bump of okio. But please don't start pushing every minor bump as an upgrade, it takes effort for reviewers and churn of PRs.

@yschimke
Copy link
Collaborator

yschimke commented Aug 2, 2021

openjdk8 build is failing with

> Task :samples:compare:test

JettyHttpClientTest > initializationError FAILED
    java.lang.UnsupportedClassVersionError: org/eclipse/jetty/client/HttpClient has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@yschimke
Copy link
Collaborator

yschimke commented Aug 2, 2021

https://webtide.com/jetty-10-and-11-have-arrived/

The minimum required Java version for Jetty 10 is now Java 11.

This is an issue as we run tests with JDK 8 to ensure compatibility.

@Goooler
Copy link
Contributor Author

Goooler commented Aug 2, 2021

https://webtide.com/jetty-10-and-11-have-arrived/

The minimum required Java version for Jetty 10 is now Java 11.

This is an issue as we run tests with JDK 8 to ensure compatibility.

Gotcha, reverted jetty-client version.

@yschimke
Copy link
Collaborator

yschimke commented Aug 2, 2021

Can you bump to okio 3.0.0-alpha.9 in this PR?

@Goooler
Copy link
Contributor Author

Goooler commented Aug 2, 2021

Can you bump to okio 3.0.0-alpha.9 in this PR?

Done.

@yschimke
Copy link
Collaborator

yschimke commented Aug 2, 2021

Sorry, not sure why it's not showing up yet. https://github.com/square/okio/releases

@Goooler
Copy link
Contributor Author

Goooler commented Aug 2, 2021

Sorry, not sure why it's not showing up yet. https://github.com/square/okio/releases

It seems like 3.0.0-alpha.9 have not been available in MavenCentral ?

image
image

@yschimke yschimke merged commit 9602d71 into square:master Aug 2, 2021
@Goooler Goooler deleted the bump branch August 2, 2021 07:25
This was referenced Aug 12, 2021
Copy link

@Kingsavage3 Kingsavage3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olay

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to usage specifically on Android graal GraalVM related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants