Convert JsonReader to Kotlin #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it sealed along the way like JsonWriter Some of the properties had different docs for setting and getting, which dokka doesn't seem to have a nice way to differentiate. Went with a little marked up form but open to suggestions.
This plays nice for both java and kotlin consumers, as it's still isLenient to java consumers but not a source breaking change for kotlin
JvmName
approved these changes
Jan 17, 2022
Comment on lines
+586
to
+590
| return buildList(strings.size) { | ||
| for (string in strings) { | ||
| add(string) | ||
| } | ||
| } |
There was a problem hiding this comment.
couldn't you just say strings.toList() or strings.map { it }?
There was a problem hiding this comment.
Collection builders return (truly) immutable instances
Co-authored-by: Parth Padgaonkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it sealed along the way like JsonWriter
Some of the properties had different docs for setting and getting, which dokka doesn't seem to have a nice way to differentiate. Went with a little marked up form but open to suggestions.