Update dokka to 1.6.10 #1497
Merged
Update dokka to 1.6.10 #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Jan 10, 2022
Done. |
ZacSweers
reviewed
Jan 10, 2022
gradle/libs.versions.toml
Outdated
| @@ -2,14 +2,15 @@ | |||
| autoService = "1.0" | |||
| gjf = "1.11.0" | |||
| jvmTarget = "1.8" | |||
| kotlin = "1.6.0" | |||
| kotlin = "1.6.10" | |||
| dokka = "1.6.10" | |||
There was a problem hiding this comment.
This isn't reused anywhere, please just keep the version in the dependency declaration like before
There was a problem hiding this comment.
Ok, deleted the dokka variable. Updating the kotlin version solved the lockstep issue. The intention is to keep the kotlin and dokka version same.
There was a problem hiding this comment.
Sure, but like I said - they are not updated at the same time
| @@ -2,14 +2,15 @@ | |||
| autoService = "1.0" | |||
| gjf = "1.11.0" | |||
| jvmTarget = "1.8" | |||
| kotlin = "1.6.0" | |||
| kotlin = "1.6.10" | |||
| dokka = "1.6.10" | |||
| kotlinCompileTesting = "1.4.6" | |||
| kotlinpoet = "1.10.2" | |||
| ksp = "1.6.0-1.0.1" | |||
There was a problem hiding this comment.
Should this be updated to 1.6.10-1.0.1 or even 1.6.10-1.0.2 to be in-sync with kotlin?
ZacSweers
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dokkais a documentation engine for Kotlin. So, it make sense to keep the same version as Kotlin.https://github.com/Kotlin/dokka/releases