Convert RecordJsonAdapter to Kotlin #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f8f3af
to
862318b
Compare
ZacSweers
commented
Jan 11, 2022
| @@ -11,20 +12,27 @@ plugins { | |||
| } | |||
|
|
|||
| val mainSourceSet by sourceSets.named("main") | |||
| val java16 by sourceSets.creating { | |||
| val java16: SourceSet by sourceSets.creating { | |||
There was a problem hiding this comment.
it was nagging me about a platform type so made it explicit
ZacSweers
commented
Jan 11, 2022
ZacSweers
commented
Jan 11, 2022
| } | ||
|
|
||
| val constructor = try { | ||
| lookup.findConstructor(rawType, methodType(knownNotNull(Void::class.javaPrimitiveType), componentRawTypes)) |
There was a problem hiding this comment.
Should we save off the knownNotNull(Void::class.javaPrimitiveType) as a top-level property?
There was a problem hiding this comment.
Is it just a better-documented !!? If it's used extensively yeah can be a top-level property.
There was a problem hiding this comment.
It skips the nullcheck
ef16c77
to
fcb9d1e
Compare
Egorand
approved these changes
Jan 11, 2022
| } | ||
|
|
||
| val constructor = try { | ||
| lookup.findConstructor(rawType, methodType(knownNotNull(Void::class.javaPrimitiveType), componentRawTypes)) |
There was a problem hiding this comment.
Is it just a better-documented !!? If it's used extensively yeah can be a top-level property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a bit of extra tweaking for the kotlin compilation task