Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Incorrect package in AndroidManifest #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajayjadhav9
Copy link

Fixed Incorrect package in AndroidManifest after upgrade to AGP 8
Bug Link : #240

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2024

CLA assistant check)
All committers have signed the CLA.

@@ -32,7 +32,7 @@ android {
def sqipCompileSdkVersion = rootProject.hasProperty('sqipCompileSdkVersion') ? rootProject.sqipCompileSdkVersion : COMPILE_SDK_VERSION
def sqipTargetSdkVersion = rootProject.hasProperty('sqipTargetSdkVersion') ? rootProject.sqipTargetSdkVersion : TARGET_SDK_VERSION
compileSdkVersion sqipCompileSdkVersion

namespace 'sqip.flutter'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation should align

@saho-ventures
Copy link

This update would help my android build related issues.

@fcanacmarquis
Copy link

I am sorry, I am not familiar with git hub review and implementation process, but I believe this was not integrated to version 1.7.9. When will this become officially available?

@supposedlysam-bb
Copy link

Is this able to get merged? New projects with Flutter v3.24.3 now default to AGP v8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants