Don't clear cache if an error was authentication-related #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d36711
to
fc77498
Compare
gyfelton
approved these changes
Nov 15, 2023
polac24
approved these changes
Nov 15, 2023
gyfelton
reviewed
Nov 15, 2023
| @@ -366,7 +373,8 @@ def retriable_error?(error) | |||
| /^fatal: pack has \d+ unresolved delta/, | |||
| /^error: unable to read sha1 file of /, | |||
| /^fatal: did not receive expected object/, | |||
| /^fatal: unable to read tree [a-z0-9]+\n^warning: Clone succeeded, but checkout failed/ | |||
| /^fatal: unable to read tree [a-z0-9]+\n^warning: Clone succeeded, but checkout failed/, | |||
| /^fatal: Authentication failed/ | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is issues with authentication (machine config or github.com issue), and I think we don't want this to be the reason that the cache is ever cleared.
This adds a new method to specifically handle an auth-related error, and also allows such errors to be retry-able (as they are sometimes transient).
Also CI was red but it seemed like Ruby env issues, so updating things on that front too.