Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Analysis: Don't recursively crawl merge subselects #5981

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jun 24, 2024

Brief summary of the change made

Allows multiple types for BaseSegment.recursive_crawl's no_recursive_seg_type
Don't analyze merge statements that may be present in subselects for object references

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17837      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling e587a7f on keraion:RF03_tsql_merge
into d4ec93f on sqlfluff:main.

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

btw @keraion - you've been tackling some really deep parts of the codebase over the last few months. Would you be interested in getting involved as a maintainer? Your github profile is fairly minimal so I can't see any contact details on there, but if you're interested - join the SQLFluff slack channel and drop me a DM. Would be great to have you as part of the team 😁 .

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Jun 26, 2024
Merged via the queue into sqlfluff:main with commit 6a11caf Jun 26, 2024
30 checks passed
@keraion keraion deleted the RF03_tsql_merge branch August 7, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants