Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebreak: Fix meta dedent segment order #5972

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jun 19, 2024

Brief summary of the change made

This fixes how rebreak recombines moved elements for the "Leading Tricky Case", namely dedent segments.

This also fixes when a rebreak doesn't have an anchor point and attempts to find the next element with segments.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17828      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 7d497e7 on keraion:LT04_ST06_complex_interaction
into e962fc1 on sqlfluff:main.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting 3 issues in 1, great job!

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jun 22, 2024
Merged via the queue into sqlfluff:main with commit a01e317 Jun 22, 2024
30 checks passed
@keraion keraion deleted the LT04_ST06_complex_interaction branch June 23, 2024 05:18
keraion added a commit to keraion/sqlfluff that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants