Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Add Support for PostGIS operators #5830

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

burhanyasar
Copy link
Contributor

Brief summary of the change made

Fixes #4260

Only by adding regex lexer for postgis operators as suggested in the discussions in the initial PR: #4824

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Only by adding regex lexer for postgis operators as suggested in the discussions in the initial PR: sqlfluff#4824
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - much cleaner than my implementation!

Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17697      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 7d0198a on burhanyasar:issue-4260-lexer-only
into 965d087 on sqlfluff:main.

@burhanyasar
Copy link
Contributor Author

LGTM - much cleaner than my implementation!

Thanks for the hint to redo it with lexer changes only.

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 30, 2024
Merged via the queue into sqlfluff:main with commit 442a583 Apr 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PostGIS operators
3 participants