Fix Hive parser error position on multiple line statement #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyyang-svail
commented
Nov 18, 2019
| @@ -61,7 +61,7 @@ public ParseResult ParseAndSplit(String sql) { | |||
| // Consider select 1 to train, Calcite parser raise error at letter t of "to", | |||
| // while HiveQL parser raise error at the white space before "to". As a result, | |||
| // we put `+ 1` on the `epos`. | |||
| epos = posToIndex(sql, re.line, re.charPositionInLine) + 1; | |||
| epos = posToIndex(sql, re.line, re.charPositionInLine + 1); | |||
There was a problem hiding this comment.
On parsing
SELECT *
FROM some_table
TO TRIAN ...
The Hive Parser gives error position as line: 3, column: 0. To make the error position at the character T of TO, we should add 1 to the column number.
There was a problem hiding this comment.
Also update the comment above?
There was a problem hiding this comment.
Sure, will do.
typhoonzero
approved these changes
Nov 19, 2019
| @@ -61,7 +61,7 @@ public ParseResult ParseAndSplit(String sql) { | |||
| // Consider select 1 to train, Calcite parser raise error at letter t of "to", | |||
| // while HiveQL parser raise error at the white space before "to". As a result, | |||
| // we put `+ 1` on the `epos`. | |||
| epos = posToIndex(sql, re.line, re.charPositionInLine) + 1; | |||
| epos = posToIndex(sql, re.line, re.charPositionInLine + 1); | |||
There was a problem hiding this comment.
Also update the comment above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1126.