Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ALPS and EDL to codegen #1179

Closed
wants to merge 7 commits into from
Closed

Move ALPS and EDL to codegen #1179

wants to merge 7 commits into from

Conversation

tonyyang-svail
Copy link
Collaborator

Part of #1126.

Also notifying @ly120983.

terrytangyuan
terrytangyuan reviewed Nov 12, 2019
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these moved to text files? What's the purpose of moving these around and commenting out if they are not working after the move?

@tonyyang-svail
Copy link
Collaborator Author

@terrytangyuan I put them as text files to disable tests.

@terrytangyuan
Copy link
Member

terrytangyuan commented Nov 12, 2019 •
edited
Loading

@tonyyang-svail What's the purpose of moving these around and commenting out if they will not be working after the move?

@tonyyang-svail
Copy link
Collaborator Author

@terrytangyuan Please allow me to explain.

I am currently working SQLFlow's parser which requires an incompatible change on ALPS and EDL. Since the code generators of ALPS and EDL will be depending on pkg/sql/codegen/intermediate_representation.go, so I am moving them from pkg/sql to pkg/codegen/engine_name.

@tonyyang-svail
Copy link
Collaborator Author

tonyyang-svail commented Nov 12, 2019 •
edited
Loading

I will come up with a smoother transition plan.

@terrytangyuan
Copy link
Member

@tonyyang-svail I see. Thanks. Please keep me posted.

@tonyyang-svail tonyyang-svail deleted the move_alps_n_edl branch November 13, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonyyang-svail @terrytangyuan