Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate third-party parser #1177

Closed
wants to merge 1 commit into from
Closed

Integrate third-party parser #1177

wants to merge 1 commit into from

Conversation

tonyyang-svail
Copy link
Collaborator

Part of #1126.

@tonyyang-svail tonyyang-svail mentioned this pull request Nov 12, 2019
Merged
@tonyyang-svail
Copy link
Collaborator Author

I file #1177 and #1180 separately for better code review. And since #1180 contains the work of #1177, and #1180 is approved, I will close #1177 and only merge #1180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyyang-svail @typhoonzero