-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support calling Java parser in SQLFlow #1171
Support calling Java parser in SQLFlow #1171
Conversation
Calling Java parser takes about 1100ms for You can reproduce the result the following command.
|
@tonyyang-svail can you write a test case that starts jvm once and run the parsing for 1000 times to see if the major time consumed is caused by starting the jvm? |
@typhoonzero I have tested it by changing the command-line argument
|
@tonyyang-svail seems so. Maybe we can merge this first and do more profiling or performance fixes in another PR. |
"-cp", "/opt/sqlflow/parser/parser-1.0-SNAPSHOT-jar-with-dependencies.jar", | ||
"org.sqlflow.parser.ParserAdaptorCmd", | ||
"-p", typ, | ||
"-i", inputFile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can refine this later using the Linux pipe to avoid writing temporary files on the disk.
I think the time is mainly costed in the startup phase after running some tests on my mac.
To avoid startup the slow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's improve the calcite
calling performance in the next PR
@weiguoz Wooow, you are awesome! |
This PR depends on #1170.
This PR is a part of #1126.